Skip to content

Fix invalid assumptions about Project ID's in BQ table #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2019
Merged

Fix invalid assumptions about Project ID's in BQ table #1708

merged 2 commits into from
May 3, 2019

Conversation

rileykarson
Copy link
Member

Upstreams hashicorp/terraform-provider-google#3486

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@rileykarson rileykarson requested a review from danawillow May 3, 2019 16:32
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rileykarson
Copy link
Member Author

This contribution is to a third_party directory subject to a different license than the rest of this repo.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of ec00944.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#658
depends: hashicorp/terraform-provider-google#3546

KJ Tsanaktsidis and others added 2 commits May 3, 2019 22:43
@modular-magician
Fix invalid assumptions about Project ID's in BQ table
fd69ff5 
The bigquery table resource tries to infer the project and dataset from
the table's full name. However, it does so incorrectly as it assumes
that the project ID cannot have : or . characters in it, yet both are
valid.
@modular-magician
Update tracked submodules -> HEAD on Fri May 3 22:43:22 UTC 2019
f9a5bb6 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 3cce1c4 into GoogleCloudPlatform:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
automerged cla: no downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileykarson @googlebot @modular-magician @danawillow