Skip to content

Test TestAccFirebaseWebApp_firebaseWebAppFull #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Dec 8, 2020

Fixes hashicorp/terraform-provider-google#7959

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Dec 8, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@edwardmedia edwardmedia requested review from ScottSuarez and removed request for c2thorn December 8, 2020 19:35
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=162145"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceSpannerInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccCloudSchedulerJob_schedulerJobHttpExample|TestAccComposerEnvironment_withUpdateOnCreate|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=162158"

@edwardmedia edwardmedia changed the title fixed TestAccFirebaseWebApp_firebaseWebAppFull Test TestAccFirebaseWebApp_firebaseWebAppFull Dec 9, 2020
@ScottSuarez
Copy link
Contributor

ScottSuarez commented Dec 10, 2020

Is this a temporary fix, are they planning to re-add these fields? @melinath I think you were working in something adjacent to this correct?

@melinath
Copy link
Member

melinath commented Dec 10, 2020

This is a separate issue - the one I'm working on is Filestore, rather than Firebase. Thanks for checking!

@edwardmedia edwardmedia requested a review from c2thorn December 12, 2020 04:40
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=162890"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceSpannerInstance_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudSchedulerJob_schedulerJobHttpExample|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_maintenance|TestAccSpannerDatabase_basic|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlDatabase_basic|TestAccSqlDatabase_update|TestAccSqlClientCert_mysql|TestAccSqlUser_postgres|TestAccSqlClientCert_postgres|TestAccSqlUser_postgresAbandon You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=162917"

@edwardmedia edwardmedia requested review from c2thorn and removed request for ScottSuarez and c2thorn December 12, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccFirebaseWebApp_firebaseWebAppFull
5 participants