Skip to content

Add Region Backend Service IAM support #5754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

caieo
Copy link
Contributor

@caieo caieo commented Feb 25, 2022

Fixes gap in RegionBackendService IAMSupport. Adds onto the fix for this issue: hashicorp/terraform-provider-google#10233

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_region_backend_service_iam_*`

Fixes gap in RegionBackendService IAMSupport
@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 242 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 478 insertions(+), 126 deletions(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@slevenick slevenick removed the request for review from melinath February 25, 2022 19:55
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 242 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 478 insertions(+), 126 deletions(-))

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccComputeRegionBackendServiceIamBindingGenerated_withAndWithoutCondition
  • TestAccComputeRegionBackendServiceIamMemberGenerated_withAndWithoutCondition

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=262107

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR

@slevenick slevenick self-requested a review February 28, 2022 16:58
@slevenick
Copy link
Contributor

/gcbrun just to make sure validator isn't really broken by this (I can't imagine why it would be)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 242 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 478 insertions(+), 126 deletions(-))

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccComputeRegionBackendServiceIamBindingGenerated_withAndWithoutCondition
  • TestAccComputeRegionBackendServiceIamMemberGenerated_withAndWithoutCondition

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=262719

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR

lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
* Add Region Backend Service IAM support 

Fixes gap in RegionBackendService IAMSupport

* Update terraform.yaml
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
* Add Region Backend Service IAM support 

Fixes gap in RegionBackendService IAMSupport

* Update terraform.yaml
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
* Add Region Backend Service IAM support 

Fixes gap in RegionBackendService IAMSupport

* Update terraform.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants