Sync 5.0.0 with main

[shuyama1]

Release Note Template for Downstream PRs (will be copied)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 121 files changed, 15855 insertions(+), 1015 deletions(-))
Terraform Beta: Diff ( 136 files changed, 16216 insertions(+), 1036 deletions(-))
TF Conversion: Diff ( 18 files changed, 2489 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 48 files changed, 1182 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_table (33 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_table" "primary" {
  materialized_view {
    allow_non_incremental_definition = # value needed
  }
  table_constraints {
    foreign_keys {
      column_references {
        referenced_column  = # value needed
        referencing_column = # value needed
      }
      name = # value needed
      referenced_table {
        dataset_id = # value needed
        project_id = # value needed
        table_id   = # value needed
      }
    }
    primary_key {
      columns = # value needed
    }
  }
}

Resource: google_compute_instance (203 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_instance_from_template (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_instance_template (128 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_region_instance_template (46 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_data_pipeline_pipeline (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_pipeline_pipeline" "primary" {
  scheduler_service_account_email = # value needed
  workload {
    dataflow_flex_template_request {
      launch_parameter {
        environment {
          flexrs_goal      = # value needed
          ip_configuration = # value needed
          kms_key_name     = # value needed
          subnetwork       = # value needed
        }
        launch_options = # value needed
      }
      validate_only = # value needed
    }
    dataflow_launch_template_request {
      launch_parameters {
        environment {
          ip_configuration = # value needed
          kms_key_name     = # value needed
          subnetwork       = # value needed
        }
      }
      validate_only = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 2942
Passed tests 2590
Skipped tests: 296
Affected tests: 56

Action taken

Found 56 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeTargetServer_apigeeTargetServerTest_update|TestAccApigeeTargetServer_apigeeTargetServerTestExample|TestAccBiglakeTable_biglakeTable_update|TestAccBiglakeTable_biglakeTableExample|TestAccCloudSchedulerJob_schedulerJobHttpExample|TestAccCloudSchedulerJob_schedulerJobPausedExample|TestAccComputeAddress_internalIpv6|TestAccComputeInstance_internalIPv6|TestAccContainerNodePool_withMultiNicNetworkConfig|TestAccContainerAttachedCluster_update|TestAccContainerAttachedCluster_containerAttachedClusterFullExample|TestAccDataPipelinePipeline_basicFlexTemplate|TestAccDataPipelinePipeline_basicLaunchTemplate|TestAccDataPipelinePipeline_dataPipelinePipelineExample|TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample|TestAccDialogflowCXTestCase_update|TestAccFirestoreDatabase_updatePitrEnablement|TestAccFirestoreDatabase_updateConcurrencyMode|TestAccFirestoreDatabase_firestoreDefaultDatabaseInDatastoreModeExample|TestAccFirestoreDatabase_firestoreDefaultDatabaseExample|TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample|TestAccFirestoreDatabase_firestoreDatabaseExample|TestAccGKEHub2Scope_gkehubScopeBasicExample_update|TestAccGKEHub2Namespace_gkehubNamespaceBasicExample_update|TestAccGKEHub2Scope_gkehubScopeBasicExample|TestAccGKEHub2ScopeIamBindingGenerated|TestAccGKEHub2ScopeIamMemberGenerated|TestAccGKEHub2ScopeIamPolicyGenerated|TestAccGKEHub2Namespace_gkehubNamespaceBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBgpLb|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateManualLb|TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample|TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterManuallbExample|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccPubsubSubscription_pushNoWrapperEmpty|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample|TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample|TestAccSecretManagerSecret_secretWithAutomaticCmekExample|TestAccStorageBucket_basicWithAutoclass|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample|TestAccStorageInsightsReportConfig_update|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPublicEndpointExample|TestAccWorkstationsWorkstationIamBindingGenerated|TestAccWorkstationsWorkstation_update|TestAccWorkstationsWorkstation_workstationBasicExample|TestAccWorkstationsWorkstationIamMemberGenerated|TestAccWorkstationsWorkstationIamPolicyGenerated

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccApigeeTargetServer_apigeeTargetServerTest_update[Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTestExample[Debug log]
TestAccBiglakeTable_biglakeTable_update[Debug log]
TestAccBiglakeTable_biglakeTableExample[Debug log]
TestAccCloudSchedulerJob_schedulerJobHttpExample[Debug log]
TestAccCloudSchedulerJob_schedulerJobPausedExample[Debug log]
TestAccComputeAddress_internalIpv6[Debug log]
TestAccComputeInstance_internalIPv6[Debug log]
TestAccContainerNodePool_withMultiNicNetworkConfig[Debug log]
TestAccContainerAttachedCluster_update[Debug log]
TestAccContainerAttachedCluster_containerAttachedClusterFullExample[Debug log]
TestAccDataPipelinePipeline_basicFlexTemplate[Debug log]
TestAccDataPipelinePipeline_basicLaunchTemplate[Debug log]
TestAccDataPipelinePipeline_dataPipelinePipelineExample[Debug log]
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample[Debug log]
TestAccDialogflowCXTestCase_update[Debug log]
TestAccFirestoreDatabase_updatePitrEnablement[Debug log]
TestAccFirestoreDatabase_updateConcurrencyMode[Debug log]
TestAccFirestoreDatabase_firestoreDefaultDatabaseInDatastoreModeExample[Debug log]
TestAccFirestoreDatabase_firestoreDefaultDatabaseExample[Debug log]
TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample[Debug log]
TestAccFirestoreDatabase_firestoreDatabaseExample[Debug log]
TestAccGKEHub2Scope_gkehubScopeBasicExample_update[Debug log]
TestAccGKEHub2Namespace_gkehubNamespaceBasicExample_update[Debug log]
TestAccGKEHub2Scope_gkehubScopeBasicExample[Debug log]
TestAccGKEHub2ScopeIamBindingGenerated[Debug log]
TestAccGKEHub2ScopeIamMemberGenerated[Debug log]
TestAccGKEHub2ScopeIamPolicyGenerated[Debug log]
TestAccGKEHub2Namespace_gkehubNamespaceBasicExample[Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update[Debug log]
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic[Debug log]
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBgpLb[Debug log]
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateManualLb[Debug log]
TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterManuallbExample[Debug log]
TestAccGkeonpremBareMetalCluster_gkeonpremBareMetalClusterManuallbExample[Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample[Debug log]
TestAccMonitoringMonitoredProject_projectNumLongForm[Debug log]
TestAccMonitoringMonitoredProject_projectNumShortForm[Debug log]
TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample[Debug log]
TestAccPubsubSubscription_pushNoWrapperEmpty[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccSecretManagerSecret_automaticCmekUpdate[Debug log]
TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample[Debug log]
TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample[Debug log]
TestAccSecretManagerSecret_secretWithAutomaticCmekExample[Debug log]
TestAccStorageBucket_basicWithAutoclass[Debug log]
TestAccStorageInsightsReportConfig_update[Debug log]
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPublicEndpointExample[Debug log]
TestAccWorkstationsWorkstationIamBindingGenerated[Debug log]
TestAccWorkstationsWorkstation_update[Debug log]
TestAccWorkstationsWorkstation_workstationBasicExample[Debug log]
TestAccWorkstationsWorkstationIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationIamPolicyGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample[Error message] [Debug log]
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 121 files changed, 15854 insertions(+), 1015 deletions(-))
Terraform Beta: Diff ( 136 files changed, 16215 insertions(+), 1036 deletions(-))
TF Conversion: Diff ( 18 files changed, 2489 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 48 files changed, 1182 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (203 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_instance_from_template (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_instance_template (128 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_region_instance_template (46 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_data_pipeline_pipeline (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_pipeline_pipeline" "primary" {
  scheduler_service_account_email = # value needed
  workload {
    dataflow_flex_template_request {
      launch_parameter {
        environment {
          flexrs_goal      = # value needed
          ip_configuration = # value needed
          kms_key_name     = # value needed
          subnetwork       = # value needed
        }
        launch_options = # value needed
      }
      validate_only = # value needed
    }
    dataflow_launch_template_request {
      launch_parameters {
        environment {
          ip_configuration = # value needed
          kms_key_name     = # value needed
          subnetwork       = # value needed
        }
      }
      validate_only = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3036
Passed tests 2724
Skipped tests: 304
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryTable_ForeignKey|TestAccBigQueryTable_MaterializedView_NonIncremental_basic|TestAccBigQueryTable_PrimaryKey|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update|TestAccBigQueryTable_updateTableConstraints|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTable_ForeignKey[Debug log]
TestAccBigQueryTable_MaterializedView_NonIncremental_basic[Debug log]
TestAccBigQueryTable_PrimaryKey[Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update[Debug log]
TestAccBigQueryTable_updateTableConstraints[Debug log]
TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic[Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample[Debug log]
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[shuyama1]

tgc failed with error:

Step #17 - "tgc-test": github.com/GoogleCloudPlatform/terraform-google-conversion/v2/cai2hcl imports
Step #17 - "tgc-test":     github.com/hashicorp/terraform-provider-google-beta/google-beta: module github.com/hashicorp/terraform-provider-google-beta@latest found (v1.20.0, replaced by github.com/modular-magician/terraform-provider-google-beta@v1.20.1-0.20230914035502-a4946bde9df0), but does not contain package github.com/hashicorp/terraform-provider-google-beta/google-beta
Step #17 - "tgc-test": GO111MODULE=on go test -short ./...
Step #17 - "tgc-test": go: updates to go.mod needed; to update it:
Step #17 - "tgc-test":     go mod tidy
Step #17 - "tgc-test": make: *** [Makefile:7: test] Error 1
Step #17 - "tgc-test":   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Step #17 - "tgc-test":                                  Dload  Upload   Total   Spent    Left  Speed

I think it might be related to some recent change and GoogleCloudPlatform/terraform-google-conversion@d1699f0 should fix it (?). I cherry-pick it the 5.0.0 branch in tgc repo. Rerun the build now.

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 121 files changed, 15854 insertions(+), 1015 deletions(-))
Terraform Beta: Diff ( 136 files changed, 16215 insertions(+), 1036 deletions(-))
TF Conversion: Diff ( 18 files changed, 2489 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 48 files changed, 1182 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (203 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_instance_from_template (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_instance_template (128 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_compute_region_instance_template (46 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  network_interface {
    internal_ipv6_prefix_length = # value needed
    ipv6_address                = # value needed
  }
}

Resource: google_data_pipeline_pipeline (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_pipeline_pipeline" "primary" {
  scheduler_service_account_email = # value needed
  workload {
    dataflow_flex_template_request {
      launch_parameter {
        environment {
          flexrs_goal      = # value needed
          ip_configuration = # value needed
          kms_key_name     = # value needed
          subnetwork       = # value needed
        }
        launch_options = # value needed
      }
      validate_only = # value needed
    }
    dataflow_launch_template_request {
      launch_parameters {
        environment {
          ip_configuration = # value needed
          kms_key_name     = # value needed
          subnetwork       = # value needed
        }
      }
      validate_only = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3036
Passed tests 2731
Skipped tests: 304
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test