Skip to content

Apply new labels model to more resources (part 3) #9000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zli82016
Copy link
Member

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 force-pushed the labels-mmv1-more-resources-3 branch from 7fdf7a1 to ed4eff2 Compare September 19, 2023 18:31
@zli82016 zli82016 force-pushed the labels-mmv1-more-resources-3 branch from 8f4f529 to 46a3c36 Compare September 19, 2023 18:38
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 41 files changed, 1002 insertions(+), 275 deletions(-))
Terraform Beta: Diff ( 47 files changed, 1173 insertions(+), 342 deletions(-))
TF Conversion: Diff ( 14 files changed, 180 insertions(+), 180 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2718
Skipped tests: 304
Affected tests: 13

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccGKEBackupBackupPlan_update|TestAccHealthcareDicomStore_basic|TestAccHealthcareFhirStore_basic|TestAccHealthcareHl7V2Store_basic|TestAccNetworkConnectivityServiceConnectionPolicy_update|TestAccNetworkSecurityAddressGroups_update|TestAccDataSourceSecretManagerSecret_basic|TestAccSecretManagerSecret_import|TestAccSecretManagerSecret_versionAliasesUpdate|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_userManagedCmekUpdate|TestAccSecretManagerSecret_cmek|TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkSecurityAddressGroups_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccGKEBackupBackupPlan_update[Error message] [Debug log]
TestAccHealthcareDicomStore_basic[Error message] [Debug log]
TestAccHealthcareFhirStore_basic[Error message] [Debug log]
TestAccHealthcareHl7V2Store_basic[Error message] [Debug log]
TestAccNetworkConnectivityServiceConnectionPolicy_update[Error message] [Debug log]
TestAccDataSourceSecretManagerSecret_basic[Error message] [Debug log]
TestAccSecretManagerSecret_import[Error message] [Debug log]
TestAccSecretManagerSecret_versionAliasesUpdate[Error message] [Debug log]
TestAccSecretManagerSecret_automaticCmekUpdate[Error message] [Debug log]
TestAccSecretManagerSecret_userManagedCmekUpdate[Error message] [Debug log]
TestAccSecretManagerSecret_cmek[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 47 files changed, 1077 insertions(+), 332 deletions(-))
Terraform Beta: Diff ( 53 files changed, 1248 insertions(+), 399 deletions(-))
TF Conversion: Diff ( 14 files changed, 180 insertions(+), 180 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2726
Skipped tests: 304
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccGKEBackupBackupPlan_update|TestAccHealthcareFhirStore_basic|TestAccHealthcareDicomStore_basic|TestAccHealthcareHl7V2Store_basic|TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEBackupBackupPlan_update[Debug log]
TestAccHealthcareFhirStore_basic[Debug log]
TestAccHealthcareDicomStore_basic[Debug log]
TestAccHealthcareHl7V2Store_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants