Skip to content

fix: correct ignored filename extensions #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix: correct ignored filename extensions #4042

merged 1 commit into from
Mar 25, 2025

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Mar 25, 2025

Description

Updates the list of ignored files to the exact matches. We have many config files but they are either .yaml or .yml, so update the list accordingly.

Should prevent issues like in #4029 where all checks are firing unexpectedly

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue where checks were unexpectedly firing due to incorrect filename extensions in the ignored files list. The changes update the .github/config/nodejs-dev.jsonc and .github/config/nodejs-prod.jsonc files to use the correct .yml extension for blunderbuss and header-checker-lint configuration files, instead of .yaml. This ensures that the intended files are ignored, preventing the checks from firing unexpectedly.

Highlights

  • Bug Fix: Corrects filename extensions in ignored files list to prevent unexpected checks from firing.
  • Configuration Update: Updates .github/config/nodejs-dev.jsonc and .github/config/nodejs-prod.jsonc to use .yml extension for specific configuration files.

Changelog

  • .github/config/nodejs-dev.jsonc
    • Changed .github/blunderbuss.yaml to .github/blunderbuss.yml in the ignored files list.
    • Changed .github/header-checker-lint.yaml to .github/header-checker-lint.yml in the ignored files list.
  • .github/config/nodejs-prod.jsonc
    • Changed .github/blunderbuss.yaml to .github/blunderbuss.yml in the ignored files list.
    • Changed .github/header-checker-lint.yaml to .github/header-checker-lint.yml in the ignored files list.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A YAML file, or is it YML?
A simple change, yet crucial still.
With extensions right,
The checks take flight,
And peace of mind, the codebase fill.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the ignored files list to use exact matches for .yaml and .yml extensions. This should address the issue of checks firing unexpectedly due to broader matching. The changes look straightforward and correct.

Merge Readiness

The changes appear correct and address the described issue. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. Given the straightforward nature of the fix, it seems ready to merge once reviewed by another member.

@glasnt glasnt marked this pull request as ready for review March 25, 2025 21:40
@glasnt glasnt requested review from a team as code owners March 25, 2025 21:40
@glasnt glasnt merged commit 3423636 into main Mar 25, 2025
11 checks passed
@glasnt glasnt deleted the yaaaamal branch March 25, 2025 21:51
rudrakhsha-crest pushed a commit to rudrakhsha-crest/nodejs-docs-samples that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants