Skip to content

Style(secretmanager): Update the region tags to match other languages. #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

archana-9430
Copy link
Contributor

Description

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@archana-9430 archana-9430 requested review from a team as code owners May 15, 2025 18:49
Copy link

snippet-bot bot commented May 15, 2025

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels May 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @archana-9430, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. This PR, authored by @archana-9430, focuses on a style update within the Secret Manager regional samples. The primary goal is to ensure consistency in the region tags used in the Node.js samples, aligning them with the naming conventions used in samples for other programming languages. Specifically, it updates the region tags in two files to include _with_regional_secret for clarity and uniformity.

Highlights

  • Style/Documentation Update: The core change is a stylistic update to the documentation region tags within the Secret Manager samples.
  • Region Tag Consistency: Updates region tags in two files to match naming conventions used in other language samples, specifically adding _with_regional_secret.

Changelog

  • secret-manager/regional_samples/iamGrantAccessWithRegionalSecret.js
    • Updated the start region tag from secretmanager_iam_grant_access_regional_secret to secretmanager_iam_grant_access_with_regional_secret (lines 18).
    • Updated the end region tag from secretmanager_iam_grant_access_regional_secret to secretmanager_iam_grant_access_with_regional_secret (lines 64).
  • secret-manager/regional_samples/iamRevokeAccessWithRegionalSecret.js
    • Updated the start region tag from secretmanager_iam_revoke_access_regional_secret to secretmanager_iam_revoke_access_with_regional_secret (lines 18).
    • Updated the end region tag from secretmanager_iam_revoke_access_regional_secret to secretmanager_iam_revoke_access_with_regional_secret (lines 72).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Tags guide the code,
Consistent names help us see,
Docs now match the rest.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the region tags in comments within two JavaScript files to ensure consistency with conventions used in other languages. This is a good, focused change that improves the maintainability and usability of these samples, likely for documentation generation or automated tooling. The changes are clear and directly address the stated purpose.

Summary of Findings

  • Region Tag Consistency: The primary change in this PR is the update of region tags (e.g., secretmanager_iam_grant_access_regional_secret to secretmanager_iam_grant_access_with_regional_secret). This enhances consistency across different language samples, which is beneficial for documentation and tooling. This type of improvement is generally considered low severity. Due to the review settings to only comment on medium, high, or critical issues, no specific review comments have been added for these changes, as they are positive and minor.

Merge Readiness

The changes in this pull request are straightforward and improve the consistency of region tags. No issues of medium or higher severity were identified. The code appears to be in good shape for merging. As always, ensure all CI checks pass and any other necessary reviews are completed before merging. I am not authorized to approve the pull request.

@iennae iennae merged commit 5fa1ee2 into main May 15, 2025
17 checks passed
@iennae iennae deleted the secretmanager-update-region-tags branch May 15, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants