Skip to content

Add field httpKeepAliveTimeoutSec to resources google_compute_region_target_http_proxy and google_compute_region_target_https_proxy #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Add the httpKeepAliveTimeoutSec field to Region Target HTTP Proxy and Region Target HTTPS Proxy resources.

fixes hashicorp/terraform-provider-google#16230

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `http_keep_alive_timeout_sec` to resource `google_region_compute_target_http_proxy`
compute: added field `http_keep_alive_timeout_sec` to resource `google_region_compute_target_https_proxy`

Derived from GoogleCloudPlatform/magic-modules#11634

…target_http_proxy and google_compute_region_target_https_proxy (#11634)

[upstream:9b8f317ddadc86b5fc6d56060cb8b5fbf7324b8f]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 10, 2024 16:28
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team September 10, 2024 16:28
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 415f88b into GoogleCloudPlatform:main Sep 10, 2024
3 of 4 checks passed
@modular-magician modular-magician deleted the downstream-pr-9b8f317ddadc86b5fc6d56060cb8b5fbf7324b8f branch November 18, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant