Skip to content

Public outbound ip #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

This PR adds the enableOutboundPublicIp boolean field and outboundPublicIpAddresses (output only field) to the AlloyDB instance resource. Setting this field to true enables public outbound IP within the AlloyDB instance. PR addresses (b/353749975). It also adds testing which covers:

  1. Creating an instance with the enableOutboundPublicIp set to true
  2. Updating an instance with the enableOutboundPublicIp set to false
  3. Updating an instance with the enableOutboundPublicIp set to true

Release Note Template for Downstream PRs (will be copied)

alloyDB: added `enableOutboundPublicIp` field to `google_alloydb_instance` resource

Derived from GoogleCloudPlatform/magic-modules#11675

[upstream:477e5c94b4011b01a7f18ccd14fbcecd6d1073eb]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 11, 2024 16:53
@modular-magician modular-magician requested review from shuyama1 and removed request for a team September 11, 2024 16:53
@modular-magician modular-magician merged commit c18ae89 into GoogleCloudPlatform:main Sep 11, 2024
3 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-477e5c94b4011b01a7f18ccd14fbcecd6d1073eb branch November 18, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant