Add support for regional secret resource google_secret_manager_regional_secret
#2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal_secret` (#11678) [upstream:3084e72fbb69daba66bf7164f10a7b6af3a82d4a] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
shuyama1
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-3084e72fbb69daba66bf7164f10a7b6af3a82d4a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new regional secret resource
google_secret_manager_regional_secret. I have also defined theiam_policyfield in the RegionalSecret.yaml file to include the IAM resources and IAM datasources as well.More info about regional secrets: https://cloud.google.com/secret-manager/docs/regional-secrets-overview
Notes:
RegionalSecret.yamlfile, the versionAliases field is commented and the respective test cases covered in theresource_secret_manager_regional_secret_test.go.erbfile are also commented because this field depends on creating regional_secret_version_resource. We intend to uncomment once this PR is merged and dependent tests can pass.ResourceSecret.yamlfile will be updated later.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11678