Fix removing host_error_timeout_seconds that was broken due to an API bug
#2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI bug (#11798) [upstream:8d575cda4c44eb16814af21559c1e7f7f21f91a7] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
roaks3
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit 13fd070
into
GoogleCloudPlatform:main
4 of 5 checks passed
modular-magician
deleted the
downstream-pr-8d575cda4c44eb16814af21559c1e7f7f21f91a7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references GoogleCloudPlatform/magic-modules#11652
When this parameter is removed or set to null it couldn't be removed because the instances.SetScheduling API method doesn't remove parameters that are not mentioned in the request (contrary to for example instances.Update).
nullcannot be sent directly in the request on anIntfield because it's rounded to 0 in go.So this is a workaround to clear the field when a user removes it's value and
0ornilin go is taken asnullin the APIRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11798