Skip to content

Fix permadiff on boot_disk.initialize_params.resource_policies #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

closes hashicorp/terraform-provider-google#19525

  • Made the field Computed
  • Added test for this specific case

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue where the `boot_disk.initialize_params.resource_policies` field in `google_compute_instance` forced a resource recreation when used in combination with `google_compute_disk_resource_policy_attachment`

Derived from GoogleCloudPlatform/magic-modules#11753

Co-authored-by: Zhenhua Li <[email protected]>

[upstream:a53010ff962996081aa267759a35919306cd4f93]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 30, 2024 20:11
@modular-magician modular-magician requested review from melinath and removed request for a team September 30, 2024 20:11
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 918321e into GoogleCloudPlatform:main Sep 30, 2024
4 of 6 checks passed
@modular-magician modular-magician deleted the downstream-pr-a53010ff962996081aa267759a35919306cd4f93 branch November 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Breaking Change: google_compute_instance addition of resource_policies
1 participant