Add increased length & Unicode tagkey and tagvalue shortname support #2881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(#11827) Co-authored-by: Nick Elliot <[email protected]> [upstream:faf28013d0c42a059c4c63ed89558ce2900369c3] Signed-off-by: Modular Magician <[email protected]>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit bba4a21
into
GoogleCloudPlatform:main
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagKeys and TagValues already support increased length tagkey and tagValue shortnames. They now also support UTF-8 encoded Unicode characters. Making necessary changes for Terraform to bring parity with other clients such as gcloud.
Ref: https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing#creating_tag
Part of b/368039508
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11827