Skip to content

Migrate Network Firewall Policy Association (global and region) resource from DCL to MMv1 #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

Hello folks.
This PR is to move two Network Firewall Policy Association resources (global and region) from DCL to MMv1.

  • google_compute_network_firewall_policy_association
  • google_compute_region_network_firewall_policy_association

And this PR includes:

  • Creation of the resource on MMv1.
  • Creation of the examples and tests.
  • Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_network_firewall_policy_association` now uses MMv1 engine instead of DCL.
compute: `google_compute_region_network_firewall_policy_association` now uses MMv1 engine instead of DCL.

Derived from GoogleCloudPlatform/magic-modules#11366

…rce from DCL to MMv1 (#11366)

Co-authored-by: Cameron Thornton <[email protected]>

[upstream:9a1402bf3fa39860cad1fb258010cbf01450e8d8]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner October 23, 2024 00:37
@modular-magician modular-magician requested review from shuyama1 and removed request for a team October 23, 2024 00:37
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit ee889f2 into GoogleCloudPlatform:main Oct 23, 2024
3 checks passed
@modular-magician modular-magician deleted the downstream-pr-9a1402bf3fa39860cad1fb258010cbf01450e8d8 branch November 18, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant