Add support for IPv6 addresses with the google_compute_external_vpn_gateway terraform resource #3004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gateway terraform resource (#11982) [upstream:c02979592736f19e34d38036a86468d62dcc53c2] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
iyabchen
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-c02979592736f19e34d38036a86468d62dcc53c2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the design doc, go/arcus-outer-vpn-ipv6. The support for IPv6 is present for Outer HA VPN, and support for IPV6 address is present in the api implementation and gcloud for external_vpn_gateway. I see the field, ipv6_address which is the IPv6 address of the interface in the external VPN gateway, Is missing in the terraform implementation for external vpn gateway. Adding the missing ipv6_address field in the yaml file.
Derived from GoogleCloudPlatform/magic-modules#11982