Updated resource "Region Security Policy" to allow for rule creation when creating the policy resource #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when creating the policy resource (#11894) Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:81a9344c674a5ed872fd91dfc9561748fbd3661e] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit 3b435f1
into
GoogleCloudPlatform:main
4 of 6 checks passed
modular-magician
deleted the
downstream-pr-81a9344c674a5ed872fd91dfc9561748fbd3661e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated resource "google_compute_region_security_policy" to allow rule creation at the same time when creating the policy. Functionality similar to what you can do with google_compute_security_policy.
It fixes a current issue that you cannot override the default created rule when (or after) creating a regional security policy. A default allow rule gets created at the same time, which cannot be controlled/changed without jumping through hoops to manually import it into your state: hashicorp/terraform-provider-google#15687
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11894