bump terraform-plugin-sdk/v2 2.23 -> 2.26
#3412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
drive-by /gcbrun |
|
fixed. I need anothe trigger on the GHA @shuyama1 |
|
/gcbrun |
any chance you can resolve merge conflicts to test and approve right away? The quick merges to main are causing constant merge conflicts. |
|
/gcbrun |
shuyama1
approved these changes
Feb 7, 2025
|
@shuyama1 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is necessary to get successful tests from passing in
terraform-google-conversionas we use sdk/v2 2.26.0 for the latest work on ephemeral write-only support.We see that the following GHA is due to errors in the tests. https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/13170402493/job/36759965728
Upon more investigation i found that when building the tgc repo locally I found that it's due to version mismatch with sdk/v2
upon updating
sdk/v2to the latest version ingo.modand runninggo mod tidyI resolve the errors.GoogleCloudPlatform/magic-modules#12800 is dependent on this PR in order for it to be moved into review.