Add methods for type-aware functions, change errors and panics #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
force-pushed
the
no-or-die
branch
4 times, most recently
from
e89de98 to
5de5ada
Compare
natasha41575
approved these changes
Oct 7, 2022
go/fn/errors.go
Outdated
| @@ -71,3 +41,20 @@ type ErrInternalAnnotation struct { | |||
| func (e *ErrInternalAnnotation) Error() string { | |||
| return e.Message | |||
| } | |||
| func NewErrUnmatchedField(obj SubObject, fields []string, dt any) *ErrUnmatchedField { | |||
There was a problem hiding this comment.
nit: Should this have a doc comment, and the below ErrUnmatchedField type?
There was a problem hiding this comment.
Done. also changed the arg dt to expectedFieldType
yuwenma
force-pushed
the
no-or-die
branch
5 times, most recently
from
0dca0a9 to
b89ad53
Compare
- Avoid panic style error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #631
panicstyle code flow control. Use specific errorsNestedResource,NestedInt64and deprecate theGetmethods.Getcan be overused and cause inefficiency of KRM function editing. we should not encourage such patternNestedXXOrDieandSetNestedXXXOrDiefunctions. Update the return error with the specific KRM resource GVK and field paths.