Skip to content

Add Results method and Context #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2022
Merged

Add Results method and Context #631

merged 4 commits into from
Oct 7, 2022

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Oct 6, 2022

This PR does 3 jobs

  • It adds Results methods.
  • It allow Context to control the flow.
  • It split results from previous context

@yuwenma yuwenma requested a review from droot as a code owner October 6, 2022 23:12
@yuwenma yuwenma removed the request for review from natasha41575 October 6, 2022 23:12
@yuwenma yuwenma mentioned this pull request Oct 6, 2022
Merged
natasha41575
natasha41575 reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes! Just some nits

@yuwenma yuwenma force-pushed the context branch 5 times, most recently from 8831621 to a054588 Compare October 7, 2022 05:21
natasha41575
natasha41575 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuwenma yuwenma force-pushed the context branch 3 times, most recently from d75d35b to 1a3ac7e Compare October 7, 2022 17:08
@yuwenma yuwenma merged commit 926c864 into kptdev:master Oct 7, 2022
@yuwenma yuwenma deleted the context branch October 7, 2022 18:09
@yuwenma yuwenma mentioned this pull request Oct 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@natasha41575 natasha41575 natasha41575 approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwenma @droot @natasha41575