Skip to content

Build args should handle keys that are defined multiple times #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgageot opened this issue Sep 25, 2018 · 0 comments
Closed

Build args should handle keys that are defined multiple times #1024

dgageot opened this issue Sep 25, 2018 · 0 comments
Assignees
@dgageot
Labels
kind/bug Something isn't working

Comments

@dgageot
Copy link
Contributor

dgageot commented Sep 25, 2018

If a build arg is defined twice, the first value should not be used after the build arg is redefined.

This Dockerfile:

ARG key=value
RUN echo $key
ARG key=value2
RUN echo $key

Should output:

value
value2

Currently, it outputs

value
value
@dgageot dgageot added kind/bug Something isn't working build/dockerfile labels Sep 25, 2018
@dgageot dgageot self-assigned this Sep 25, 2018
dgageot added a commit to dgageot/skaffold that referenced this issue Sep 26, 2018
@dgageot
Fix issues with build args replacement
d2f3c67 
Fixes GoogleContainerTools#1025
Fixes GoogleContainerTools#1024
and other issues…

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot mentioned this issue Sep 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgageot