Skip to content

Skaffold init --analyze should do the same validations as skaffold init. #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sujit-kamireddy opened this issue Mar 14, 2019 · 0 comments · Fixed by #1810
Closed

Skaffold init --analyze should do the same validations as skaffold init. #1795

sujit-kamireddy opened this issue Mar 14, 2019 · 0 comments · Fixed by #1810
Labels
kind/bug Something isn't working

Comments

@sujit-kamireddy
Copy link

Expected behavior

When there are no valid DockerFile or kubernetes manifests in the directory, skaffold init --analyze should provide errors as skaffold init does.
Ex:
FATA[0000] one or more valid Dockerfiles must be present to run skaffold; please provide at least one Dockerfile and try again
FATA[0000] one or more valid kubernetes manifests is required to run skaffold

Actual behavior

Skaffold init --analyze doesn't provide any error info.

Information

  • Skaffold version: version...7212422
  • Operating system: ... Windows
  • Contents of skaffold.yaml: NA
<paste your skaffold.yaml here>

Steps to reproduce the behavior

  1. Create a directory that doesn't have valid DockerFiles or kubernetes manifests
  2. Run skaffold init --analyze and skaffold init.
@balopat balopat added the kind/bug Something isn't working label Mar 14, 2019
priyawadhwa pushed a commit to priyawadhwa/skaffold-1 that referenced this issue Mar 15, 2019
Error out if no Dockerfiles are found
f8d1489 
This should fix GoogleContainerTools#1795; now, if no Dockerfiles are found in the workspace
then skaffold will error out. If no k8s manifests are found it will
error out (already implemented).
@priyawadhwa priyawadhwa mentioned this issue Mar 15, 2019
Merged
priyawadhwa pushed a commit to priyawadhwa/skaffold-1 that referenced this issue Mar 15, 2019
Error out if no Dockerfiles are found
0211c2c 
This should fix GoogleContainerTools#1795; now, if no Dockerfiles are found in the workspace
then skaffold will error out. If no k8s manifests are found it will
error out (already implemented).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error if no Dockerfiles are found for skaffold init --analyze priyawadhwa/skaffold-1
2 participants
@balopat @sujit-kamireddy