helm integration tests flake #1823
Assignees
Comments
tejal29
added a commit
to tejal29/skaffold
that referenced
this issue
May 10, 2019
1. Add kubectl apply command after setting labels 2. Integration tests for helms are back a. GoogleContainerTools#1823: Use env template in skaffold release name 3. During helm deploy, build is assumed and hence if no build-artifacts are supplied, it fails with following error "no build present for gcr.io/k8s-skaffold/skaffold-helm" Since Build and Deploy are now separate ( GoogleContainerTools#922 for notes) use the image value as is if not present as build artifacts TODO: 1. Add PR description 2. Figure out why we get 2 pods, 1 with valid labels which is running but another 1 with different labels.
tejal29
added a commit
to tejal29/skaffold
that referenced
this issue
May 10, 2019
1. Add kubectl apply command after setting labels 2. Integration tests for helms are back a. GoogleContainerTools#1823: Use env template in skaffold release name 3. During helm deploy, build is assumed and hence if no build-artifacts are supplied, it fails with following error "no build present for gcr.io/k8s-skaffold/skaffold-helm" Since Build and Deploy are now separate ( GoogleContainerTools#922 for notes) use the image value as is if not present as build artifacts Fix test fot this. TODO: 1. Add PR description 2. Figure out why we get 2 pods, 1 with valid labels which is running but another 1 with different labels.
tejal29
added a commit
to tejal29/skaffold
that referenced
this issue
May 13, 2019
1. Add kubectl apply command after setting labels 2. Integration tests for helms are back a. GoogleContainerTools#1823: Use env template in skaffold release name 3. During helm deploy, build is assumed and hence if no build-artifacts are supplied, it fails with following error "no build present for gcr.io/k8s-skaffold/skaffold-helm" Since Build and Deploy are now separate ( GoogleContainerTools#922 for notes) use the image value as is if not present as build artifacts Fix test fot this. TODO: 1. Add PR description 2. Figure out why we get 2 pods, 1 with valid labels which is running but another 1 with different labels.
tejal29
added a commit
to tejal29/skaffold
that referenced
this issue
May 16, 2019
…dding namespace label as post fix to the release name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes helm release
skaffold-helmstays in the cluster breaking subsequent integration tests as helm release names have to be globally unique regardless of namespace (see design reason for this).As @tejal29 recommended, we should create a separate release name for each test - which can be achieved by leaving the release name empty.
(alternatively a less elegant solution is to clean up the
skaffold-helmrelease if it's stuck for some weird reason from previous integration tests)The text was updated successfully, but these errors were encountered: