Add support for Kustomize Kustomization resources #2416
Assignees
Labels
Comments
jmcclell
changed the title
|
@dgageot This is probably actually a bug rather than a feature request, because today if you use version 2.1 and opt to use the new resource functionality rather than bases, Skaffold won't properly watch all the files as it won't follow the dependency tree. I'm putting a PR together now. |
jmcclell
added a commit
to jmcclell/skaffold
that referenced
this issue
Jul 5, 2019
As of version 2.1, Kustomize has deprecated bases in favor of combining the functionality with resources by enforcing merge order based on resource array order. This means resources now may act as bases do today instead of being simply files - they may point to kustomiziations (directories with a kustomization config in the root) or even to remote locations. The code to generate the list of dependencies for file watching has been updated accordingly.
|
great |
jmcclell
added a commit
to jmcclell/skaffold
that referenced
this issue
Jul 5, 2019
As of version 2.1, Kustomize has deprecated bases in favor of combining the functionality with resources by enforcing merge order based on resource array order. This means resources now may act as bases do today instead of being simply files - they may point to kustomiziations (directories with a kustomization config in the root) or even to remote locations. The code to generate the list of dependencies for file watching has been updated accordingly.
This was referenced Jul 5, 2019
dgageot
pushed a commit
that referenced
this issue
Jul 9, 2019
As of version 2.1, Kustomize has deprecated bases in favor of combining the functionality with resources by enforcing merge order based on resource array order. This means resources now may act as bases do today instead of being simply files - they may point to kustomiziations (directories with a kustomization config in the root) or even to remote locations. The code to generate the list of dependencies for file watching has been updated accordingly.
|
Closed by the merge of #2420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of version 2.1, Kustomize has deprecated the concept of "bases" in favor of combining the concept into the "resources" array by enforcing merge order. This means that as of 2.1, a resource can refer to a Kustomization (a directory containing a kustomization config at its root) rather than simply a file. This means that Skaffold's Kustomization support needs to be expanded to treat resources as if they are potentially bases in order to properly construct the dependency array for file monitoring.
This also tangentially relates to Issue #2082 (fixed in PR #2269), as the handling of resources needs to to take into account the possibility that they may now be remote just like bases were.
The text was updated successfully, but these errors were encountered: