Skip to content

Add metrics for debug/iterations #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IsaacPD opened this issue Feb 3, 2021 · 0 comments · Fixed by #5359
Closed

Add metrics for debug/iterations #5348

IsaacPD opened this issue Feb 3, 2021 · 0 comments · Fixed by #5359
Labels
area/metrics Metrics tracking work for skaffold kind/feature-request priority/p2 May take a couple of releases

Comments

@IsaacPD
Copy link
Contributor

IsaacPD commented Feb 3, 2021

Expected behavior

Metrics for debug iterations are exported and collected

Actual behavior

Only metrics for dev iterations are being collected as can be seen here

skaffold/pkg/skaffold/instrumentation/export.go

Lines 201 to 203 in e66f04c

if meter.Command == "dev" {
iterationCounter := metric.Must(m).NewInt64ValueRecorder("dev/iterations",
metric.WithDescription("Number of iterations in a dev session"))

@IsaacPD IsaacPD added kind/feature-request area/metrics Metrics tracking work for skaffold labels Feb 3, 2021
@IsaacPD IsaacPD mentioned this issue Feb 5, 2021
Merged
@nkubala nkubala added the priority/p2 May take a couple of releases label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/metrics Metrics tracking work for skaffold kind/feature-request priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add debug/iterations metric IsaacPD/skaffold
2 participants
@nkubala @IsaacPD