Skip to content

add debug/iterations metric #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

IsaacPD
Copy link
Contributor

@IsaacPD IsaacPD commented Feb 5, 2021

Fixes: #5348

Description

Export debug/iterations in addition to dev/iterations metric.

@IsaacPD IsaacPD requested a review from a team as a code owner February 5, 2021 17:56
@google-cla google-cla bot added the cla: yes label Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #5359 (52ea51a) into master (0ba3ee7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5359      +/-   ##
==========================================
- Coverage   71.55%   71.52%   -0.03%     
==========================================
  Files         395      395              
  Lines       14409    14409              
==========================================
- Hits        10310    10306       -4     
- Misses       3333     3335       +2     
- Partials      766      768       +2     
Impacted Files Coverage Δ
pkg/skaffold/instrumentation/export.go 76.56% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba3ee7...52ea51a. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarlonGamez MarlonGamez merged commit bd5c84b into GoogleContainerTools:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for debug/iterations
3 participants