-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Skaffold not waiting for deployments to stabilize #5966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ananyasaxena Can you please add some trace logs? |
Nope, I can see it taking time on the k8s dashboard and also using v1.23.0 waits correctly for it to stabilize |
@ananyasaxena is it possible to provide a small example to reproduce your issue? I think PR #6010 might help here, but I need a way to test it. Otherwise you can build my branch from source or wait for it to be merged to use the |
@gsquared94 I'll try building from your branch, if I run into any challenges I'll just wait for the merge and release to test this out and report back. |
@ananyasaxena my PR was merged so you can also try with the bleeding edge version (https://skaffold.dev/docs/install/)
|
@ananyasaxena is this a still an issue? |
@gsquared94 @tejal29 I used https://storage.googleapis.com/skaffold/builds/latest/skaffold-linux-amd64 but still ran into the same issue
|
Thanks for confirming @ananyasaxena. I will look into this |
Same problem here
after i upgrading from v1.27.0 to v1.28.0 |
@ananyasaxena @somnistudio we haven't been seeing this in any of our testing, so it seems like this might be specific to your project setups. would either of you be able/willing to provide a small sample project for us to reproduce this issue? |
I'm facing the same issue with apiVersion: skaffold/v2beta5
kind: Config
profiles:
- name: dev-skaffold
build:
tagPolicy:
sha256: { }
artifacts:
- image: someDevRegistryWithRepo
buildpacks:
builder: paketobuildpacks/builder:base
deploy:
kustomize:
paths: [ k8s/overlays/dev-skaffold ]
- name: dev-cluster
deploy:
kustomize:
paths: [ k8s/overlays/dev-cluster ] skaffold -p dev-cluster deploy --images=registry.gitlab.com/XXX --tag=0.7.0 --status-check Which yields:
when using run in favor of deploy everything works as expected. skaffold -p dev-cluster run
I also wonder if there is an option to silence this |
@cmdjulian could you provide a log running with |
Sure the log yields the following for
|
for the run command I'm seeing the following:
|
When using the latest version from
I'm using k3s if this helps and my |
I'm also experiencing this problem using skaffold 1.32.0. My deployments report being stabilised in a few milliseconds when using Strangely Using kubernetes v1.20.9, istio 1.11.2, and kustomize 4.3 |
This appears to have been fixed for me in 1.33.0. I suspect the change was #6674 which fixed it. Thanks :) |
Hey @simonjpartridge, after updating to the newest version 1.33.0 I see normal deployment times. It appears to be fixed for me as well. |
closing for now, please comment to reopen if it reoccurs. |
Seeing this issue again with the Skaffold 2.0 release. Pinning to v1.39.2 fixes it. |
@afallou can you add some more information on the skaffold.yaml used when you encountered this (esp. what k8s objects were deployed - |
Here is a sample deployment that this seems to occur for:
|
I could not repro this issue. I tried against pods and deployments and this app mentioned above. I tried against skaffold main branch, along with v2.0.2 and v2.0.3, and against minikube and GKE clusters. It is possible that this regression existed in v2.0.0 release but I think that release has been archived and the earliest available version is now v2.0.2. Closing it again. Please provide the exact kubernetes manifest with a prebuilt image that I can pull and run as repro to reopen. |
Making triage party happy |
Note: The Skaffold team are unable to reproduce this issue. If you see this issue, please attach a trace from running with
-vtrace
or provide a sample repository.**Expected behavior & Actual behavior
On version 1.23.0, skaffold would wait for deployments to stabilize correctly
After v1.24.0, it doesn't seem to be waiting for deployments to stabilize
Information
The text was updated successfully, but these errors were encountered: