Skip to content

Skaffold fix should output the changed json to a file #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tejal29 opened this issue Aug 18, 2021 · 2 comments · Fixed by #6849
Closed

Skaffold fix should output the changed json to a file #6456

tejal29 opened this issue Aug 18, 2021 · 2 comments · Fixed by #6849
Labels
area/fix help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request planning/Q4-21 Q4 2021 planning priority/p2 May take a couple of releases source/partnerships
Milestone

Comments

@tejal29
Copy link
Contributor

tejal29 commented Aug 18, 2021

from @chairy's discussion from v3 config upgrade,

Right now skaffold fix outputs the new config on to StdOut.

Add a flag to store the updated config to a a file --output so IDES can specify the updated skaffold config file and show it the diff to users.

../../../skaffold/out/skaffold fix
apiVersion: skaffold/v2beta21
kind: Config
metadata:
  name: java-guestbook
build:
  artifacts:
  - image: backend
    context: backend
    docker:
      dockerfile: Dockerfile
  - image: frontend
    context: frontend
    docker:
      dockerfile: Dockerfile
deploy:
  kubectl:
    manifests:
    - backend/deployment.yaml
    - frontend/deployment.yaml
portForward:
- resourceType: service
  resourceName: backend
  port: 8080
- resourceType: service
  resourceName: frontend
  port: 8080

@tejal29 tejal29 added area/fix source/partnerships planning/Q4-21 Q4 2021 planning planning/Q3-21 help wanted We would love to have this done, but don't have the bandwidth, need help from contributors labels Aug 18, 2021
@tejal29
Copy link
Contributor Author

tejal29 commented Aug 18, 2021

/cc @etanshaul

@tejal29 tejal29 added the priority/p2 May take a couple of releases label Aug 18, 2021
@briandealwis briandealwis changed the title Skaffold fix should output the changed json for IDEs to consume Skaffold fix should output the changed json to a file Aug 19, 2021
@briandealwis
Copy link
Member

Retitled as it would be useful for CLI users too.

@tejal29 tejal29 added this to the v1.35.0 milestone Oct 13, 2021
ahmetb added a commit to ahmetb/skaffold that referenced this issue Nov 11, 2021
- introduced --output/-o (mut.exclusive with --overwrite)
- add more examples
- add more integration tests

Fixes GoogleContainerTools#6456.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
ahmetb added a commit to ahmetb/skaffold that referenced this issue Nov 12, 2021
- introduced --output/-o (mut.exclusive with --overwrite)
- add more examples
- add more integration tests

Fixes GoogleContainerTools#6456.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
ahmetb added a commit to ahmetb/skaffold that referenced this issue Nov 12, 2021
- introduced --output/-o (mut.exclusive with --overwrite)
- add more examples
- add more integration tests

Fixes GoogleContainerTools#6456.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
tejal29 pushed a commit that referenced this issue Nov 12, 2021
- introduced --output/-o (mut.exclusive with --overwrite)
- add more examples
- add more integration tests

Fixes #6456.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fix help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request planning/Q4-21 Q4 2021 planning priority/p2 May take a couple of releases source/partnerships
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants