Skip to content

Support system's LDFLAGS, make compilation reproducible #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

maximbaz
Copy link
Contributor

  • Supporting $LDFLAGS provided by the build system for example allows enabling RELRO.
  • Using -trimpath in -gcflags and -asmflags makes your application reproducible.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

Codecov Report

Merging #1270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   42.42%   42.42%           
=======================================
  Files          96       96           
  Lines        4247     4247           
=======================================
  Hits         1802     1802           
  Misses       2269     2269           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce2352...b131eb9. Read the comment docs.

@maximbaz
Copy link
Contributor Author

Signed CLA

@googlebot
Copy link

CLAs look good, thanks!

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Nov 15, 2018
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 15, 2018
@balopat balopat merged commit 412ec74 into GoogleContainerTools:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants