Skip to content

brew install skaffold #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Conversation

cedricvidal
Copy link
Contributor

Proposing to add brew install skaffold installation method to README

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

codecov-io commented Nov 18, 2018

Codecov Report

Merging #1290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   44.98%   44.98%           
=======================================
  Files         106      106           
  Lines        4737     4737           
=======================================
  Hits         2131     2131           
  Misses       2385     2385           
  Partials      221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52cc32...d11e379. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, can you please sign the CLA?

@dgageot
Copy link
Contributor

dgageot commented Nov 22, 2018

Hello @cedricvidal, thanks for the PR! I'm afraid you need to both rebase your code and sign the CLA before we can merge.

@cedricvidal
Copy link
Contributor Author

You're welcome @dgageot , that's weird, I signed it already, I'll try again.

@googlebot
Copy link

CLAs look good, thanks!

@cedricvidal
Copy link
Contributor Author

ok ... lol, at exactly the same time I reply, the @googlebot acknowledges my CLA ^^

Proposing to add `brew install skaffold` installation method to README
@cedricvidal
Copy link
Contributor Author

@dgageot rebased

@dgageot dgageot merged commit 2b067eb into GoogleContainerTools:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants