-
Notifications
You must be signed in to change notification settings - Fork 1.7k
brew install skaffold #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew install skaffold #1290
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Codecov Report
@@ Coverage Diff @@
## master #1290 +/- ##
=======================================
Coverage 44.98% 44.98%
=======================================
Files 106 106
Lines 4737 4737
=======================================
Hits 2131 2131
Misses 2385 2385
Partials 221 221 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you, can you please sign the CLA?
Hello @cedricvidal, thanks for the PR! I'm afraid you need to both rebase your code and sign the CLA before we can merge. |
You're welcome @dgageot , that's weird, I signed it already, I'll try again. |
CLAs look good, thanks! |
ok ... lol, at exactly the same time I reply, the @googlebot acknowledges my CLA ^^ |
Proposing to add `brew install skaffold` installation method to README
@dgageot rebased |
Proposing to add
brew install skaffold
installation method to README