Cleanup only if something was actually deployed #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
- Coverage 44.78% 44.75% -0.03%
==========================================
Files 114 114
Lines 4890 4902 +12
==========================================
+ Hits 2190 2194 +4
- Misses 2477 2485 +8
Partials 223 223
Continue to review full report at Codecov.
|
nkubala
reviewed
Nov 30, 2018
pkg/skaffold/runner/runner.go
Outdated
| @@ -260,6 +266,13 @@ func (r *SkaffoldRunner) BuildAndTest(ctx context.Context, out io.Writer, artifa | |||
| return bRes, err | |||
| } | |||
|
|
|||
| // Deploy deployes the given artifacts | |||
| // Deploy deployes the given artifacts | ||
| func (r *SkaffoldRunner) Deploy(ctx context.Context, out io.Writer, artifacts []build.Artifact) ([]deploy.Artifact, error) { | ||
| dRes, err := r.Deployer.Deploy(ctx, out, artifacts) | ||
| r.hasDeployed = true |
There was a problem hiding this comment.
I guess it's not different than what we had before, but if Deploy() errors out do we want to set this flag?
There was a problem hiding this comment.
I guess it could fail and have deployed a few things. We want to clean this up
There was a problem hiding this comment.
yeah, not really a good way to know whether or not that's the case so let's just be safe.
Signed-off-by: David Gageot <[email protected]>
Fix GoogleContainerTools#812 Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
nkubala
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #812