Skip to content

If webhook deployment fails, upload logs #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2018

Conversation

priyawadhwa
Copy link
Contributor

If the webhook deployment fails, upload logs to GCS and comment a link
to the logs. If that fails, then comment on the PR that there was an
error in creating the deployment.

Tested on PR 1175, comment here.

If the webhook deployment fails, upload logs to GCS and comment a link
to the logs. If that fails, then comment on the PR that there was an
error in creating the deployment.
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just a few style nits but the logic LGTM

@codecov-io
Copy link

Codecov Report

Merging #1348 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
- Coverage   45.03%   44.95%   -0.09%     
==========================================
  Files         114      114              
  Lines        4912     4921       +9     
==========================================
  Hits         2212     2212              
- Misses       2475     2482       +7     
- Partials      225      227       +2
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 64.35% <0%> (-1.22%) ⬇️
cmd/skaffold/app/cmd/init.go 15.34% <0%> (-0.08%) ⬇️
cmd/skaffold/app/cmd/run.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/labels.go 0% <0%> (ø) ⬆️
pkg/skaffold/kubernetes/log.go 6.89% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a314b3e...7ab61f8. Read the comment docs.

@priyawadhwa priyawadhwa merged commit 6108a26 into GoogleContainerTools:master Dec 7, 2018
@priyawadhwa priyawadhwa deleted the webhook branch December 7, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants