Skip to content

Pass tag options by value #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 7, 2018

Simplifies the code and prepares the work on tagging

Signed-off-by: David Gageot [email protected]

Simplifies the code

Signed-off-by: David Gageot <[email protected]>
@codecov-io
Copy link

codecov-io commented Dec 7, 2018

Codecov Report

Merging #1372 into master will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   44.91%   44.88%   -0.03%     
==========================================
  Files         114      114              
  Lines        4925     4919       -6     
==========================================
- Hits         2212     2208       -4     
+ Misses       2486     2485       -1     
+ Partials      227      226       -1
Impacted Files Coverage Δ
pkg/skaffold/build/gcb/cloud_build.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/kaniko/kaniko.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/tag/custom.go 37.5% <100%> (+7.5%) ⬆️
pkg/skaffold/build/local/local.go 51.78% <100%> (ø) ⬆️
pkg/skaffold/build/tag/git_commit.go 84.37% <100%> (ø) ⬆️
pkg/skaffold/build/tag/date_time.go 47.36% <100%> (-5.02%) ⬇️
pkg/skaffold/build/tag/env_template.go 88% <100%> (ø) ⬆️
pkg/skaffold/build/tag/sha256.go 66.66% <100%> (-6.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54473e...d5b4ee8. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit b7592ab into GoogleContainerTools:master Dec 7, 2018
@dgageot dgageot deleted the tag-options-by-value branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants