Add missing tests for build/sequence.go #1575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
==========================================
+ Coverage 46.51% 46.74% +0.23%
==========================================
Files 118 118
Lines 5044 5044
==========================================
+ Hits 2346 2358 +12
+ Misses 2464 2452 -12
Partials 234 234
Continue to review full report at Codecov.
|
dgageot
suggested changes
Feb 1, 2019
pkg/skaffold/build/sequence_test.go
Outdated
| } | ||
| tagger := &MockTagger{Out: ""} | ||
|
|
||
| got, err := InParallel(context.Background(), out, tagger, artifacts, test.buildArtifact) |
There was a problem hiding this comment.
Sorry for a horrible mistake..., I fixed it!
shuheiktgw
force-pushed
the
add_tests_for_sequence
branch
from
5b11ebd to
93ad2eb
Compare
dgageot
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for build/sequence.go! Thanks! 👍