Skip to content

kubectl deployer: warn when pattern matches no file #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

kubectl deployer: warn when pattern matches no file #1647

merged 1 commit into from
Feb 13, 2019

Conversation

corneliusweig
Copy link
Contributor

Fixes #1645

@codecov-io
Copy link

codecov-io commented Feb 12, 2019 •
edited
Loading

Codecov Report

Merging #1647 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
- Coverage   46.95%   46.93%   -0.02%     
==========================================
  Files         119      119              
  Lines        5143     5145       +2     
==========================================
  Hits         2415     2415              
- Misses       2480     2481       +1     
- Partials      248      249       +1
Impacted Files Coverage Δ
pkg/skaffold/util/util.go 51.26% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c13adb...10a59a1. Read the comment docs.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Feb 13, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Feb 13, 2019
dgageot
dgageot previously requested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corneliusweig like @priyawadhwa said on the issue, we'd rather have a warning here.

@corneliusweig
Copy link
Contributor Author

@dgageot sure. That comment was later than this PR :)

@corneliusweig corneliusweig changed the title kubectl deployer: fail when pattern matches no file kubectl deployer: warn when pattern matches no file Feb 13, 2019
@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Feb 13, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Feb 13, 2019
priyawadhwa
priyawadhwa approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM

@priyawadhwa priyawadhwa dismissed dgageot’s stale review February 13, 2019 19:51

this has been fixed!

@priyawadhwa priyawadhwa merged commit fa81250 into GoogleContainerTools:master Feb 13, 2019
@corneliusweig corneliusweig deleted the manifest-exists branch February 13, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@dgageot dgageot dgageot left review comments

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corneliusweig @codecov-io @dgageot @priyawadhwa @googlebot @kokoro-team