Skip to content

feat: specify the resource requirements for the kaniko pod #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 4, 2019

Conversation

garethjevans
Copy link
Contributor

No description provided.

@garethjevans
Copy link
Contributor Author

This PR allows the user to specify the limits/requests values for the kaniko pod during a build. Our testing has found this is a more effective way of allowing the cluster to autoscale correctly.

If you're happy with this PR, let me know and I'll get some docs added.

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #1683 into master will increase coverage by 0.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage    49.8%   50.52%   +0.71%     
==========================================
  Files         180      180              
  Lines        8149     8166      +17     
==========================================
+ Hits         4059     4126      +67     
+ Misses       3708     3658      -50     
  Partials      382      382
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta7/upgrade.go 66.66% <ø> (ø) ⬆️
pkg/skaffold/build/kaniko/sources/sources.go 89.33% <100%> (+89.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9907a4...324f676. Read the comment docs.

@garethjevans
Copy link
Contributor Author

@dgageot anything else I need to do on this?

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tejal29
Copy link
Contributor

tejal29 commented Apr 2, 2019

ah nvm, ignore the "pkg/webhook/kubernetes/deployment.go" it is something internal for generating docs.

@tejal29
Copy link
Contributor

tejal29 commented Apr 2, 2019

@garethjevans I discussed this with the team and this looks good!
Since this is a config change, we have to freeze the config.
I am going to get that Pr out and then once that is in, please rebase and this PR will be ready to be merged!!

@tejal29
Copy link
Contributor

tejal29 commented Apr 3, 2019

@garethjevans Please rebase and this should be ready to merge!

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Apr 3, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 3, 2019
@tejal29 tejal29 force-pushed the kaniko-resources branch from 7b0678c to 2ec1117 Compare April 4, 2019 07:08
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 4, 2019
@garethjevans
Copy link
Contributor Author

@tejal29 the PR has been rebased and is ready to go

@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 4, 2019
@tejal29 tejal29 dismissed dgageot’s stale review April 4, 2019 18:00

contributor has addressed all the concerns

@tejal29 tejal29 merged commit 2df3067 into GoogleContainerTools:master Apr 4, 2019
@tejal29 tejal29 mentioned this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants