-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: specify the resource requirements for the kaniko pod #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: specify the resource requirements for the kaniko pod #1683
Conversation
This PR allows the user to specify the limits/requests values for the kaniko pod during a build. Our testing has found this is a more effective way of allowing the cluster to autoscale correctly. If you're happy with this PR, let me know and I'll get some docs added. |
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 49.8% 50.52% +0.71%
==========================================
Files 180 180
Lines 8149 8166 +17
==========================================
+ Hits 4059 4126 +67
+ Misses 3708 3658 -50
Partials 382 382
Continue to review full report at Codecov.
|
@dgageot anything else I need to do on this? |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
72b7a50
to
1f8af7b
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
ah nvm, ignore the "pkg/webhook/kubernetes/deployment.go" it is something internal for generating docs. |
@garethjevans I discussed this with the team and this looks good! |
@garethjevans Please rebase and this should be ready to merge! |
7b0678c
to
2ec1117
Compare
@tejal29 the PR has been rebased and is ready to go |
contributor has addressed all the concerns
No description provided.