Refactor caching #1779
Merged
Refactor caching #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 8, 2019 11:25
This should organize the cache code while moving it into pkg/skaffold/build/cache for better organization as well.
functions also update unit tests to match this change, and move local cluster into cache struct since it's commonly needed for all artifacts.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
|
@priyawadhwa Looks like there's still a few Gofmt errors |
|
That's weird... |
|
@priyawadhwa Could you rebase? |
…o refactor-caching
dgageot
approved these changes
Mar 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #1779 +/- ##
=========================================
+ Coverage 46.4% 46.71% +0.3%
=========================================
Files 132 135 +3
Lines 6322 6347 +25
=========================================
+ Hits 2934 2965 +31
+ Misses 3087 3083 -4
+ Partials 301 299 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored caching and moved it into
pkg/skaffold/build/cache, as described in #1765I split up the giant
cache.gofile into four smaller ones:cache.gowhich initializes theCachetypehash.gowhich contains all functions related to getting workspace hashes for artifactsretrieve.gowhich is responsible for retrieving an artifact from the cache and deciding if it needs to be rebuilt/retagged/repushed and executing those actionssave.gowhich saves artifacts to the cache