Make integration tests shorter and more stable #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
dgageot
force-pushed
the
improve-test-logs-and-polling
branch
from
691432e to
cfb994b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
==========================================
- Coverage 46.08% 45.49% -0.59%
==========================================
Files 142 142
Lines 6577 6607 +30
==========================================
- Hits 3031 3006 -25
- Misses 3243 3301 +58
+ Partials 303 300 -3
Continue to review full report at Codecov.
|
|
kokoro seems to be running forever. Let's wait for the logs to see if the changes help the debugging |
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
improve-test-logs-and-polling
branch
from
cfb994b to
bc2a13a
Compare
|
Let's try to run this PR a few times: |
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
improve-test-logs-and-polling
branch
3 times, most recently
from
735ccd2 to
c07b12a
Compare
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
improve-test-logs-and-polling
branch
from
c07b12a to
88b4e68
Compare
This makes it faster to build on the CI Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
improve-test-logs-and-polling
branch
from
8e611af to
85b3c9c
Compare
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Also update the development guide Signed-off-by: David Gageot <[email protected]>
dgageot
changed the title
Signed-off-by: David Gageot <[email protected]>
balopat
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the integration tests to make them easier to debug and more reliable.
Also make TravisCI run faster by not fetching the submodules