Check for artifacts in cache in parallel #1799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks for artifacts in the cache in parallel, continues work on #1740
On my desktop, with all cache hits, I noticed these speedups after adding this parallelization:
hipster shop microservices example (11 images)
with this PR:
Cache check complete in 800.688356ms
Cache check complete in 785.371388ms
Cache check complete in 820.054476ms
currently at HEAD:
Cache check complete in 5.104418923s
Cache check complete in 5.149867178s
Cache check complete in 5.250693574s
skaffold/examples/microservices (2 images)
with this PR:
Cache check complete in 507.760169ms
Cache check complete in 533.770901ms
Cache check complete in 497.994918ms
currently at HEAD:
Cache check complete in 1.004895467s
Cache check complete in 1.552249704s
Cache check complete in 1.12099431s