Refactor Wait Utils Into Watchers #1811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
suggested changes
Mar 16, 2019
g-harel
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
|
@g-harel can you fix the lint issue and rebase please? |
g-harel
force-pushed
the
wait-watchers
branch
2 times, most recently
from
016a4cd to
0b0c2fe
Compare
|
@dgageot done! |
Codecov Report
@@ Coverage Diff @@
## master #1811 +/- ##
==========================================
- Coverage 47.98% 47.83% -0.16%
==========================================
Files 143 143
Lines 6483 6504 +21
==========================================
Hits 3111 3111
- Misses 3089 3110 +21
Partials 283 283
Continue to review full report at Codecov.
|
dgageot
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1170
This PR refactors wait utils into watchers.
I also updated
WaitForDeploymentToStabilizeto handlectx.Done(). Behavior should otherwise not be affected.