Improve test coverage #1840
Merged
Improve test coverage #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Signed-off-by: David Gageot <[email protected]>
It’s currently waiting for all the tests to end to print the output Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
improve-test-coverage
branch
from
d0255a7 to
ec9239c
Compare
Signed-off-by: David Gageot <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1840 +/- ##
==========================================
+ Coverage 47.91% 49.64% +1.72%
==========================================
Files 144 165 +21
Lines 6499 7145 +646
==========================================
+ Hits 3114 3547 +433
- Misses 3101 3270 +169
- Partials 284 328 +44
Continue to review full report at Codecov.
|
|
I still don't understand how Codecov is computing coverage... |
dgageot
force-pushed
the
improve-test-coverage
branch
from
ec9239c to
beed7c2
Compare
balopat
reviewed
Mar 20, 2019
test.sh
Outdated
| @@ -21,7 +21,8 @@ GREEN='\033[0;32m' | |||
| RESET='\033[0m' | |||
|
|
|||
| echo "Running go tests..." | |||
| go test -count=1 -race -cover -short -timeout 60s -coverprofile=out/coverage.txt -covermode=atomic ./... | grep -v 'no test files' | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' | |||
| go test -cover -short -timeout=60s -coverprofile=out/coverage.txt -coverpkg="./pkg/...,./cmd/..." ./... | awk -v FAIL="${RED}FAIL${RESET}" '! /no test files/ { gsub("FAIL", FAIL, $0); print $0 }' | |||
There was a problem hiding this comment.
this removes the race detector - is that intentional?
dgageot
force-pushed
the
improve-test-coverage
branch
from
beed7c2 to
d2abf81
Compare
Not just on the package the test belongs to Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
improve-test-coverage
branch
from
d2abf81 to
ca96952
Compare
|
@balopat should be all good now |
balopat
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the coverage of a few pieces of code.
It also configures
go testso that test coverage is counted on every package, not the package that the test belongs to. This should show our real test coverage.