-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix unnecessary warning in caching #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If an image is built remotely, we don't want to try to retag/push it locally, otherwise we get an unnecessary warning that caching may not work. (I know we haven't finished deciding what to do with caching for spring cleanup yet, but we need this fix for the demo me and @dgageot are working on!) :)
thanks @balopat ! |
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
==========================================
+ Coverage 50.16% 50.24% +0.08%
==========================================
Files 168 168
Lines 7356 7354 -2
==========================================
+ Hits 3690 3695 +5
+ Misses 3310 3300 -10
- Partials 356 359 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the urgency around the demo - but I think we shouldn't merge this without putting a test around the failing use case. I might be able to help with that too, if you're okay with me meddling in your PR.
@balopat don't mind at all! I wasn't exactly sure what kind of test to write, since the retagging wasn't failing, it was just unnecessary. I changed the name of the function to |
If an image is built remotely, we don't want to try to retag/push it locally, otherwise we get an unnecessary warning that caching may not work.
(I know we haven't finished deciding what to do with caching for spring cleanup yet, but we need this fix for the demo me and @dgageot are working on!) :)