Skip to content

Remove some dead code #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 24, 2019

No description provided.

dgageot added 3 commits April 24, 2019 23:22
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #2017 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
+ Coverage   55.63%   55.72%   +0.08%     
==========================================
  Files         173      173              
  Lines        7515     7503      -12     
==========================================
  Hits         4181     4181              
+ Misses       2942     2931      -11     
+ Partials      392      391       -1
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 66.87% <ø> (+3.86%) ⬆️
pkg/skaffold/color/formatter.go 90.9% <ø> (+7.57%) ⬆️
pkg/skaffold/schema/v1alpha1/upgrade.go 70.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd8e57...64293d4. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my preferred way of increasing code coverage 👌

@nkubala nkubala merged commit 7b329b5 into GoogleContainerTools:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants