Add option to configure the networking stack in docker build #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cornelius Weig <[email protected]>
…ker builder This fixes an issue on AWS where docker builds need to be done with `--network=host`. Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
requested review from
balopat,
briandealwis,
chanseokoh,
dgageot,
loosebazooka,
nkubala,
priyawadhwa,
TadCordle and
tejal29
as code owners
corneliusweig
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
+ Coverage 55.96% 56.09% +0.13%
==========================================
Files 173 175 +2
Lines 7566 7607 +41
==========================================
+ Hits 4234 4267 +33
- Misses 2928 2932 +4
- Partials 404 408 +4
Continue to review full report at Codecov.
|
|
how do I go about unsubscribing from this mailing list these are things that don't apply to me in life because great people like you are working on it and I don't need to be a part of something greater than me at this point in time please unsubscribe me
Sent from Yahoo Mail on Android.
On Fri, Apr 26, 2019 at 5:39 PM, Codecov<[email protected]> wrote:
Codecov Report
Merging #2036 into master will increase coverage by 0.13%.
The diff coverage is 85.18%.
@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
+ Coverage 55.96% 56.09% +0.13%
==========================================
Files 173 175 +2
Lines 7566 7607 +41
==========================================
+ Hits 4234 4267 +33
- Misses 2928 2932 +4
- Partials 404 408 +4
| Impacted Files | Coverage Δ | |
| pkg/skaffold/schema/versions.go | 74.35% <ø> (ø) | ⬆️ |
| pkg/skaffold/schema/latest/config.go | 100% <ø> (ø) | ⬆️ |
| pkg/skaffold/schema/validation/validation.go | 100% <100%> (ø) | ⬆️ |
| pkg/skaffold/schema/v1beta8/upgrade.go | 58.2% <100%> (ø) | ⬆️ |
| pkg/skaffold/docker/image.go | 72.12% <100%> (+0.51%) | ⬆️ |
| pkg/skaffold/schema/v1beta9/config.go | 100% <100%> (ø) | |
| pkg/skaffold/schema/v1beta9/upgrade.go | 66.66% <66.66%> (ø) | |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a68f2a...1ec8e3d. Read the comment docs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@Mavericktx2 I think you must have either requested to watch this repository. You should see an option to unsubscribe or unwatchable if you visit the githubb page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue on AWS where the docker builder must be run with
--network=host. This PR makes it possible to configure the networking stack of the docker builder via theskaffold.yaml.Fixes #1771
Note: This also includes commit 9810d58 because the new option should be mentioned in the additions list in
upgrade.go