Skip to content

Add k8 style managed by label to skaffold deployed pods #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented May 1, 2019

Fixes #2045

This PR will works with internal metrics gathering logic.

Summary of Changes:

  1. Add a labeller to deployer in the Runner so that all the labeller will be propagated to all the deployers.
  2. Remove the existing default labels which was only added in deploying with helm deployer.

@tejal29 tejal29 requested review from dgageot and priyawadhwa May 1, 2019 22:18
@tejal29 tejal29 requested review from balopat and nkubala as code owners May 1, 2019 22:18
@codecov-io
Copy link

Codecov Report

Merging #2055 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2055      +/-   ##
=========================================
+ Coverage   56.04%   56.1%   +0.05%     
=========================================
  Files         179     180       +1     
  Lines        7742    7750       +8     
=========================================
+ Hits         4339    4348       +9     
+ Misses       2987    2986       -1     
  Partials      416     416
Impacted Files Coverage Δ
pkg/skaffold/deploy/labels.go 16.04% <ø> (+0.19%) ⬆️
pkg/skaffold/runner/runner.go 64.77% <100%> (+0.2%) ⬆️
pkg/skaffold/runner/labeller.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15868fb...d0aed16. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejal29 tejal29 merged commit 25f1b66 into GoogleContainerTools:master May 3, 2019
@tejal29 tejal29 deleted the add_labels branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kubernetes Label managed-by for skaffold metrics
4 participants