Use test wrapper in more tests #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
briandealwis,
chanseokoh,
loosebazooka,
nkubala,
priyawadhwa,
TadCordle and
tejal29
as code owners
Signed-off-by: David Gageot <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
+ Coverage 58.1% 58.15% +0.05%
==========================================
Files 188 188
Lines 7869 7869
==========================================
+ Hits 4572 4576 +4
+ Misses 2924 2922 -2
+ Partials 373 371 -2
Continue to review full report at Codecov.
|
tejal29
approved these changes
Jun 6, 2019
|
|
||
| if test.shouldErrSet { | ||
| if test.shouldErr { | ||
| // if we expect an error when setting, don't try and unset | ||
| return | ||
| } | ||
|
|
||
| // unset the value | ||
| err = unsetConfigValue(test.key) | ||
| newConfig, cfgErr := readConfig() |
There was a problem hiding this comment.
not an issue with this PR. But we shd de-couple testing set and unset behavior in the same test into 2 separate tests.
| "reflect" | ||
| ) | ||
|
|
||
| func (t *T) CheckErrorAndTypeEquality(shouldErr bool, err error, expected, actual interface{}) { |
There was a problem hiding this comment.
Very nice! There were times when i felt i shd check error type!
Thank you for adding this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot [email protected]