-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add status check flag #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status check flag #2338
Conversation
5e52880
to
46186c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some nits :)
I think we can make the flag hidden in cobra? That way we could merge this!
Codecov Report
|
7daef31
to
7be3a6f
Compare
7be3a6f
to
1acfb9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Introduce status check flag in the deploy flow and some basic tests.
TODO:
Add health check logic for deployments
Add healthcheck logic for pods.
Coming soon!