Skip to content

Add status check flag #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Jun 26, 2019

Introduce status check flag in the deploy flow and some basic tests.

TODO:
Add health check logic for deployments
Add healthcheck logic for pods.

Coming soon!

@tejal29 tejal29 force-pushed the add_status_check_flag branch from 5e52880 to 46186c1 Compare June 26, 2019 06:16
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some nits :)
I think we can make the flag hidden in cobra? That way we could merge this!

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #2338 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/config/options.go 100% <ø> (ø) ⬆️
cmd/skaffold/man/man.go 88.23% <100%> (ø) ⬆️
pkg/skaffold/runner/runner.go 68.21% <100%> (+1.55%) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <100%> (ø) ⬆️

@tejal29 tejal29 force-pushed the add_status_check_flag branch from 7daef31 to 7be3a6f Compare June 27, 2019 18:39
@tejal29 tejal29 force-pushed the add_status_check_flag branch from 7be3a6f to 1acfb9a Compare June 27, 2019 18:41
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tejal29 tejal29 merged commit 13a66b2 into GoogleContainerTools:master Jun 27, 2019
@tejal29 tejal29 deleted the add_status_check_flag branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants