The user is now able to disable RPC in dev mode #2427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
dgageot
force-pushed
the
disable-rpc
branch
4 times, most recently
from
f1aa4f9 to
9dea388
Compare
Signed-off-by: David Gageot <[email protected]>
None of those tests is GCP only Signed-off-by: David Gageot <[email protected]>
|
ping @nkubala |
nkubala
approved these changes
Jul 10, 2019
| // TODO(dgageot): api server is always started in dev mode, right now. | ||
| // It should instead default to true. | ||
| // In dev mode, the default is to enable the rpc server | ||
| if cmd.Use == "dev" && !cmd.Flag("enable-rpc").Changed { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot [email protected]