Add resync/rebuild directly in monitor callback #2438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
dgageot
suggested changes
Jul 10, 2019
dgageot
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small refactor to clean the code up a bit, this code doesn't make much sense in the dev loop IMO.
the small functional effect of this change is that instead of erroring out the dev loop if we encounter an error when creating the sync item (note: this is not the same as if an actual sync error occurred), this will now log a warn to the user when skaffold tries to add the artifact to the
changeSet, but the dev loop will continue. we could also log this as an error if that seems more appropriate.