Make Jib test projects more lightweight #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandealwis
requested review from
balopat,
chanseokoh,
dgageot,
loosebazooka,
nkubala,
priyawadhwa,
TadCordle and
tejal29
as code owners
|
@briandealwis This seems to have no impact on test duration on kokoro. but it looks good to me |
dgageot
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration/testdata/jibandintegration/testdata/debug/jib) to use the built-in HTTP server from the JDK rather than pull in Spring Boot. Build times for these projects goes from about 17s to 9s when all artifacts are downloaded from scratch.integration/diagnose_test.goto use the now-simplerintegration/testdata/jib.skaffold diagnosein this project goes from approx 6.9s to 5.5s.