Set artifact caching on by default #2621
Conversation
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
priyawadhwa
force-pushed
the
cache-default
branch
from
bb4b2ea to
b77fc97
Compare
Codecov Report
|
integration/debug_test.go
Outdated
| deployments: []string{"jib"}, | ||
| pods: []string{"nodejs", "npm", "python3"}, | ||
| }, | ||
| { | ||
| description: "kustomize", | ||
| args: []string{"--profile", "kustomize"}, |
There was a problem hiding this comment.
is there a reason why we turn off caching for these two tests?
There was a problem hiding this comment.
never mind. just saw your commit message "Add --cache-artifacts=false for integrationt tests where we check builds"
There was a problem hiding this comment.
but these are debug test? do we still need to disable caching?
priyawadhwa
force-pushed
the
cache-default
branch
from
4749467 to
67074fe
Compare
priyawadhwa
force-pushed
the
cache-default
branch
from
6e28bff to
b02554b
Compare
This integration test for caching makes sure a build event is sent even if all artifacts are cached. This is necessry for the IDEs, which use the initial build event to determine a new dev loop has started.
|
cc @nkubala could you PTAL at the event additions and integration test? |
|
eventing and integration test look fine. in the future it might be cool to add some information in the build event itself about whether or not it was built from cache, something like |
Fixes #2511